REF: groupby remove _selection_name #41401
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
reviewed
May 10, 2021
pandas/core/groupby/generic.py
Outdated
| @@ -1042,6 +1029,16 @@ def aggregate(self, func=None, *args, engine=None, engine_kwargs=None, **kwargs) | |||
|
|
|||
| agg = aggregate | |||
|
|
|||
| @property | |||
There was a problem hiding this comment.
hmm can you kill this last one?
|
great |
JulianWgs
pushed a commit
to JulianWgs/pandas
that referenced
this pull request
Jul 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use self._selected_obj and self._obj_with_exclusions in different places with no clear distinction as to when to use which. I think in pretty much all cases we really want obj_with_exclusions, am moving towards pinning that down.
The only non-trivial thing here is getting rid of pinning _selection in here. We have no tests that reach that. I can cook up a case that gets there, but haven't found any cases where removing it actually changes anything.