Skip to content

WIP: groupby skipna #41399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

mayukh18
Copy link

@mayukh18 mayukh18 commented May 9, 2021

New duplicate of #15772 since I had lost the previous branch. Work in progress.

@pep8speaks
Copy link

Hello @mayukh18! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 349:89: E501 line too long (101 > 88 characters)
Line 365:89: E501 line too long (89 > 88 characters)

Line 1303:89: E501 line too long (102 > 88 characters)
Line 1716:89: E501 line too long (103 > 88 characters)

Line 717:9: E265 block comment should start with '# '
Line 731:9: E265 block comment should start with '# '
Line 809:17: E265 block comment should start with '# '

@github-actions
Copy link
Contributor

This pull request is stale because it has been open for thirty days with no activity. Please update or respond to this comment if you're still interested in working on this.

@github-actions github-actions bot added the Stale label Jun 24, 2021
@mroeschke
Copy link
Member

Thanks for the PR, but while this is a WIP PR it appears further development has gone stale. For drafts we suggest marking as such in the Github UI in the future. Closing but happy to reopen if interested in further developement

@geoffrey-eisenbarth
Copy link
Contributor

cc: @mzeitlin11

I'm interested in getting skipna to work on groupby (see #39983 for my use now that level is no longer a parameter for sum, and #15675 for the general issue), but I'm not very familiar with Cython. I can definitely take the initial PR as is and take care of linting issues and whatsnew, but could use some guidance on what kind of tests would be necessary.

@mzeitlin11
Copy link
Member

cc: @mzeitlin11

I'm interested in getting skipna to work on groupby (see #39983 for my use now that level is no longer a parameter for sum, and #15675 for the general issue), but I'm not very familiar with Cython. I can definitely take the initial PR as is and take care of linting issues and whatsnew, but could use some guidance on what kind of tests would be necessary.

Sounds great, that would be awesome! If you can put up a new pr with what you mention above and ping me, I'd be happy to help out with any cython / discussion of tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ENH: enable skipna on groupby reduction ops
6 participants