[ArrowStringArray] TST: parametrize str.extract tests #41393
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonjayhawkins
added
Testing
jreback
approved these changes
May 10, 2021
|
|
||
| # two normal groups, one non-capturing group | ||
| result = Series(["A11", "B22", "C33"]).str.extract( | ||
| "([AB])([123])(?:[123])", expand=False | ||
| s = Series(["A11", "B22", "C33"], dtype=any_string_dtype) |
There was a problem hiding this comment.
feel free to break up really long tests like this (followon), unless easy to view in the same one
pandas/tests/strings/test_extract.py
Outdated
|
|
||
| @pytest.mark.parametrize( | ||
| "index", | ||
| [ | ||
| tm.makeStringIndex, | ||
| tm.makeUnicodeIndex, | ||
| tm.makeIntIndex, | ||
| tm.makeDateIndex, | ||
| tm.makePeriodIndex, | ||
| tm.makeRangeIndex, |
There was a problem hiding this comment.
in followon if can use the existing fixtures
pandas/tests/strings/test_extract.py
Outdated
| s_or_idx.str.extract("(?:[AB]).*", expand=True) | ||
|
|
||
|
|
||
| @pytest.mark.parametrize("klass", [Series, Index]) |
There was a problem hiding this comment.
i think we have a parameterization for this (followon)
|
cc @jorisvandenbossche if any comments (though prob easier to comment and handle in followon) |
|
thanks @simonjayhawkins |
JulianWgs
pushed a commit
to JulianWgs/pandas
that referenced
this pull request
Jul 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.