Skip to content

BUG: Make ExcelFile.parse pass kwds to TextParser #4139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 6, 2013

Conversation

jtratner
Copy link
Contributor

@jtratner jtratner commented Jul 5, 2013

Fixes #4131

@jtratner
Copy link
Contributor Author

jtratner commented Jul 5, 2013

test2.xlsx is a single column with the following cells:

Test
NA
1
NA
apple
rabbit

@jreback
Copy link
Contributor

jreback commented Jul 5, 2013

this looks ok to merge after #4141

@cpcloud
Copy link
Member

cpcloud commented Jul 5, 2013

@jtratner can u push again...thanks

@jtratner
Copy link
Contributor Author

jtratner commented Jul 5, 2013

rebased + pushed again.

On Fri, Jul 5, 2013 at 6:39 PM, Phillip Cloud [email protected]:

@jtratner https://github.com/jtratner can u push again...thanks


Reply to this email directly or view it on GitHubhttps://github.com//pull/4139#issuecomment-20542620
.

hayd added a commit that referenced this pull request Jul 6, 2013
BUG: Make ExcelFile.parse pass kwds to TextParser
@hayd hayd merged commit 1bd8f57 into pandas-dev:master Jul 6, 2013
@hayd
Copy link
Contributor

hayd commented Jul 6, 2013

Oops forgot update to release.rst

@jtratner
Copy link
Contributor Author

jtratner commented Jul 6, 2013

@hayd do you want me to make a new PR for that?

@jreback
Copy link
Contributor

jreback commented Jul 6, 2013

actually what we could use here is a method in io.parsers that give u back all of the default args (and values)
to avoid explicitly listing them in more than one place

used in io.parsers obviously but also here

note - maybe be a smaller subset that io.parser

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Excel parser cannot change *keep_default_na* value
4 participants