REF: document casting behavior in groupby #41376
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jbrockmendel
commented
May 8, 2021
jbrockmendel
commented
- closes #xxxx
- tests added / passed
- Ensure all linting tests pass, see here for how to run them
- whatsnew entry
rhshadrach
reviewed
May 8, 2021
| @@ -1236,12 +1233,11 @@ def _wrap_applied_output_series( | |||
| columns = key_index | |||
| stacked_values = stacked_values.T | |||
|
|
|||
| if stacked_values.dtype == object: | |||
| # We'll have the DataFrame constructor do inference | |||
| stacked_values = stacked_values.tolist() | |||
There was a problem hiding this comment.
Any perf impact by passing a list to DataFrame constructor?
There was a problem hiding this comment.
test_apply_numeric_coercion_when_datetime goes through here. running the usage in timeit looks like a wash
There was a problem hiding this comment.
i think we may be able to do better/cleaner following #40489
jreback
requested changes
May 17, 2021
pandas/core/groupby/ops.py
Outdated
| @@ -967,11 +967,22 @@ def _cython_operation( | |||
| ) | |||
|
|
|||
| @final | |||
| def agg_series(self, obj: Series, func: F) -> ArrayLike: | |||
| def agg_series(self, obj: Series, func: F, preserve: bool = False) -> ArrayLike: | |||
There was a problem hiding this comment.
preserve_dtype? I don't know if we use this keyword elsewhere
There was a problem hiding this comment.
changing to preserve_dtype
|
and perf question |
|
updated + green |
jreback
approved these changes
May 17, 2021
TLouf
pushed a commit
to TLouf/pandas
that referenced
this pull request
Jun 1, 2021
JulianWgs
pushed a commit
to JulianWgs/pandas
that referenced
this pull request
Jul 3, 2021
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.