REF: do less in Grouping.__init__ #41375
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
jreback
requested changes
May 10, 2021
| elif isinstance(self.grouper, (list, tuple)): | ||
| self.grouper = com.asarray_tuplesafe(self.grouper) | ||
|
|
||
| # a passed Categorical | ||
| elif is_categorical_dtype(self.grouper): | ||
| self._passed_categorical = True |
There was a problem hiding this comment.
why don't you just make this a property of the grouper itself?
There was a problem hiding this comment.
i think what you're suggesting is something like
@property
def _passed_categorical(self):
return is_categorical_dtype(self.grouper)
that is the longer-term goal, but ATM we treat directly-passed Categoricals differently from Categoricals derived within __init__, so that property wouldn't be quite the same as this variable. I expect that the different treatment is non-intentional, but need to track that down to be sure.
|
pls rebase (though i see a similar PR adding some of this machinery), so either ok (suspect they overlap a bit) |
|
rebased + green |
jreback
approved these changes
May 17, 2021
|
thanks. not super happy with adding state, but as you are working towards more robust ways this is fine. |
TLouf
pushed a commit
to TLouf/pandas
that referenced
this pull request
Jun 1, 2021
JulianWgs
pushed a commit
to JulianWgs/pandas
that referenced
this pull request
Jul 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
making it incrementally easier to reason about what
self.grouperis