BUG : Min/max markers on box plot are not visible with 'dark_background' (#40769) #41349
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
attack68
approved these changes
May 6, 2021
|
sorry, @yeshsurya a bit unlucky, I think this failure isn't related to your change, probably you will need another rebase |
jreback
requested changes
May 7, 2021
charlesdong1991
approved these changes
May 9, 2021
There was a problem hiding this comment.
thanks! very nice! @yeshsurya
just a minor tip: use ``dark_background`` instead of 'dark_background' would be more aligned with the syntax usually done in whatsnew notes ^^
|
thanks very much, very nice! |
JulianWgs
pushed a commit
to JulianWgs/pandas
that referenced
this pull request
Jul 3, 2021
…nd' (pandas-dev#40769) (pandas-dev#41349) * BUG : Fixing - Min/max markers on box plot are not visible with 'dark_background' (pandas-dev#40769) * DOC : Replace method path with uesr friendly version (pandas-dev#40769) * DOC : Formatting change in whatsnew note (pandas-dev#40769)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Color in boxplot.py should be a hex value. Letter based color will be at matplotlib level. Using same color as that of boxes for the caps as well. The color will be fetched based on the selected theme. We are over riding color with "k" , rather need to use the one set at matplotlib level.
Before Fix :
Caps for the box plot is not visible :
After Fix :
Caps for the box plow will be visible in dark background mode :
Whats New : Box Plot's Caps will have same color as boxes unless color is explicitly specified by user arguments. Hence theme changes will not adversly effect caps color.