Skip to content

TST: xfail incorrect test_empty_groupby #41341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 6, 2021

Conversation

jbrockmendel
Copy link
Member

In addressing #41291 i found that this test isn't constructing the DataFrame (i think) it intends to. When the construction is fixed, a bunch of the tests fail. This fixes the construction and xfails those tests.

@jreback jreback added Groupby Testing pandas testing functions or related to the test suite labels May 6, 2021
@jreback jreback added this to the 1.3 milestone May 6, 2021
# GH8093 & GH26411

if isinstance(values, Categorical) and len(keys) == 1 and method == "apply":
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, plan is to address the root cause and unxfail these as appropriate at some point?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, immediately xref #41342

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(will need to rebase #41342 after this)

@jreback jreback merged commit 3cce96f into pandas-dev:master May 6, 2021
@jbrockmendel jbrockmendel deleted the tst-test_empty_groupby branch May 6, 2021 15:08
JulianWgs pushed a commit to JulianWgs/pandas that referenced this pull request Jul 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Groupby Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants