-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
[ArrowStringDtype] Make it already a StringDtype subclass #41312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ArrowStringDtype] Make it already a StringDtype subclass #41312
Conversation
Thanks @jorisvandenbossche lgtm we could clean-up the various |
Did that here |
|
@simonjayhawkins is there an easy solution for that? (sorry, currently don't have time to dive into this, otherwise will add some ignores) |
in #39908 we add ArrowStringArray to the return types and import it in a TYPE_CHECKING block |
sure |
@simonjayhawkins this will be redundant after #39908, but in the meantime, ArrowStringDtype being a subclass would help for writing robust code related to
StringDtype
in downstream packages (for those testing against pandas master)