Bug in iloc.setitem orienting IntegerArray into the wrong direction #41288
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phofl
added
Indexing
jbrockmendel
reviewed
May 3, 2021
| @@ -164,7 +164,7 @@ def check_setitem_lengths(indexer, value, values) -> bool: | |||
| # a) not necessarily 1-D indexers, e.g. tuple | |||
| # b) boolean indexers e.g. BoolArray | |||
| if is_list_like(value): | |||
| if len(indexer) != len(value): | |||
| if len(indexer) != len(value) and values.ndim == 1: | |||
There was a problem hiding this comment.
would the ndim check here be necessary if EAs all supported 2D?
There was a problem hiding this comment.
Yes, we are passing here through with something like
df = pd.DataFrame(data={
'col1': [1, 2, 3, 4],
'col2': [3, 4, 5, 6],
'col3': [6, 7, 8, 9],
})
rhs = np.array([1, 2, 3])
df.iloc[[1]] = rhs
too. This should set row-wise, but the check assumes it sets column-wise
jreback
requested changes
May 4, 2021
| @@ -31,6 +31,7 @@ | |||
| PeriodIndex, | |||
| Series, | |||
| Timestamp, | |||
| array, | |||
There was a problem hiding this comment.
i thought we are using pd.array rather than bare array (i could be out of date here)
There was a problem hiding this comment.
Did not know that. Changed it
jreback
approved these changes
May 5, 2021
|
thanks @phofl very nice as always |
|
Thanks @jreback |
topper-123
added a commit
to topper-123/pandas
that referenced
this pull request
May 10, 2021
…ection (pandas-dev#41288)" This reverts commit c89b19f.
JulianWgs
pushed a commit
to JulianWgs/pandas
that referenced
this pull request
Jul 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is more or less a follow up of #39040, so don't think we need a whatsnew?