Allow to union MultiIndex with empty RangeIndex
#41275
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
requested changes
May 3, 2021
| @@ -414,6 +414,14 @@ def test_union_empty_self_different_names(): | |||
| tm.assert_index_equal(result, expected) | |||
|
|
|||
|
|
|||
| def test_union_multiindex_empty_rangeindex(): | |||
| # GH#41234 | |||
| mi = MultiIndex.from_arrays([[1, 2], [3, 4]], names=["a", "b"]) | |||
doc/source/whatsnew/v1.3.0.rst
Outdated
| @@ -754,6 +754,7 @@ Indexing | |||
| - Bug in :meth:`DataFrame.loc.__setitem__` when setting-with-expansion incorrectly raising when the index in the expanding axis contains duplicates (:issue:`40096`) | |||
| - Bug in :meth:`DataFrame.loc` incorrectly matching non-boolean index elements (:issue:`20432`) | |||
| - Bug in :meth:`Series.__delitem__` with ``ExtensionDtype`` incorrectly casting to ``ndarray`` (:issue:`40386`) | |||
| - Bug in :meth:`MultiIndex.union` raising for an empty ``RangeIndex`` (:issue:`41234`) | |||
There was a problem hiding this comment.
is this a bug vc 1.2.x? if not then no whatsnew is needed (instead add this issue number next to the other release note)
jreback
requested changes
May 3, 2021
jreback
requested changes
May 3, 2021
jbrockmendel
reviewed
May 4, 2021
jreback
approved these changes
May 4, 2021
|
thanks @mlondschien |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MultiIndexwith emptyRangeIndexraises #41234See also dask/dask#7610 and JDASoftwareGroup/kartothek#464. The regression seems to have been introduced in #38671.