Skip to content

Backport PR #40994: REGR: memory_map with non-UTF8 encoding #41257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 25, 2021
Merged

Backport PR #40994: REGR: memory_map with non-UTF8 encoding #41257

merged 4 commits into from
May 25, 2021

Conversation

twoertwein
Copy link
Member

@twoertwein twoertwein commented May 1, 2021 •
edited by simonjayhawkins
Loading

Backport PR #40994

@twoertwein
Copy link
Member Author

I think this PR depends on some not-backported PRs?

@simonjayhawkins simonjayhawkins added the IO CSV read_csv, to_csv label May 2, 2021
@simonjayhawkins simonjayhawkins added this to the 1.2.5 milestone May 2, 2021
@jreback
Copy link
Contributor

jreback commented May 2, 2021

this might be non-trival to make work. ping when / if ready.

@twoertwein
Copy link
Member Author

I will not have time to look into this for the next ~two weeks. The whatsnew entry should probably be moved to 1.3.

@phofl
Copy link
Member

phofl commented May 13, 2021

This makes this compatible with the logic on master

@simonjayhawkins
Copy link
Member

The whatsnew entry should probably be moved to 1.3.

this fixed a regression in 1.2 #40986 (comment), so would be good to backport.

The changes do no look trivial which would normally be desirable for a backport.

@twoertwein @phofl @jreback happy to merge this?

@phofl
Copy link
Member

phofl commented May 24, 2021

I think the only change is

            errors = self.errors if self.errors is not None else "strict"

which is necessary because we have a new keyword on master setting this flag.

@simonjayhawkins simonjayhawkins merged commit e64410f into pandas-dev:1.2.x May 25, 2021
@simonjayhawkins
Copy link
Member

Thanks @twoertwein @phofl

@twoertwein twoertwein deleted the backport branch June 5, 2021 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
IO CSV read_csv, to_csv
Projects
None yet
Milestone
1.2.5
Development

Successfully merging this pull request may close these issues.
4 participants
@twoertwein @jreback @phofl @simonjayhawkins