CLN: Small fix to clean_pyc task #4124
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hm. OK didn’t realize there was a notion of precedence here. u could try the -delete option but don't spend too much time here if this works then great. |
| @@ -5,7 +5,7 @@ clean: clean_pyc | |||
| -find . -name '*.so' -exec rm {} \; | |||
|
|
|||
| clean_pyc: | |||
| -find . -name '*.pyc' -or -name '*.pyo' -exec rm {} \; | |||
| -find . -name '*.pyc' -exec rm {} \; -or -name '*.pyo' -exec rm {} \; | |||
There was a problem hiding this comment.
you could also do find . -regex '.*\.py[co]' -delete
There was a problem hiding this comment.
@cpcloud -delete isn't universally supported (from what I've read), which is why I've avoided it.
cpcloud
added a commit
that referenced
this pull request
Jul 4, 2013
CLN: Small fix to clean_pyc task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous
clean_pycwasn't actually removing*.pycfiles - apparently each branch of find needs its own exec (I guess?). Anyways this works now.