Skip to content

BUG: to_string truncation row with index=False #41223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 21, 2021
Merged

BUG: to_string truncation row with index=False #41223

merged 4 commits into from
May 21, 2021

Conversation

mikeronayne
Copy link
Contributor

@mikeronayne mikeronayne commented Apr 29, 2021 •
edited
Loading

jreback
jreback requested changes May 5, 2021
View reviewed changes
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add a whatsnew note (nearbby the other note that is similar)

@jreback jreback added the Output-Formatting __repr__ of pandas objects, to_string label May 5, 2021
@jreback jreback added this to the 1.3 milestone May 5, 2021
@jreback
Copy link
Contributor

jreback commented May 10, 2021

lgtm. if @pandas-dev/pandas-core or @pandas-dev/pandas-triage can have a look to double check.

@ivanovmg
Copy link
Member

I checked how to_string looks on this branch.
I confirm that the new behavior is favorable.

ivanovmg
ivanovmg approved these changes May 12, 2021
View reviewed changes
Copy link
Member

@ivanovmg ivanovmg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
I checked the outputs for more complicated dataframes, with wider columns and the results looked nice.

@mikeronayne
Copy link
Contributor Author

@jreback @ivanov Is the PR ready for merge? I don't see the option to complete it from my side.

@ivanov
Copy link
Contributor

ivanov commented May 13, 2021

...@ivanov Is the PR ready for merge? I don't see the option to complete it from my side.

I think you meant to tag @ivanovmg

@mikeronayne mikeronayne requested a review from jreback May 20, 2021 17:18
@jreback jreback merged commit b04dad7 into pandas-dev:master May 21, 2021
@jreback
Copy link
Contributor

jreback commented May 21, 2021

thanks @mikeronayne

TLouf pushed a commit to TLouf/pandas that referenced this pull request Jun 1, 2021
@mikeronayne @TLouf
BUG: to_string truncation row with index=False (pandas-dev#41223)
2e59c9e
JulianWgs pushed a commit to JulianWgs/pandas that referenced this pull request Jul 3, 2021
@mikeronayne @JulianWgs
BUG: to_string truncation row with index=False (pandas-dev#41223)
6aaa066
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivanovmg ivanovmg ivanovmg approved these changes

@jreback jreback Awaiting requested review from jreback

Assignees
No one assigned
Labels
Output-Formatting __repr__ of pandas objects, to_string
Projects
None yet
Milestone
1.3
Development

Successfully merging this pull request may close these issues.

BUG: to_string with index=False incorrectly shifts truncation (ellipsis) column
4 participants
@mikeronayne @jreback @ivanovmg @ivanov