WIP: avoid zip and unzip to improve the speed of get_indexer #41177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qiuwei
commented
Apr 27, 2021
•
qiuwei
commented
- closes PERF: regression in reindex. Pandas 0.23.4 is 60x slower than 0.22.0 with a MultiIndex with datetime64 #23735 Extreme performance issue in pandas 1.0.3 when setting a new column with DatetimeIndex #34531
- tests added / passed
- Ensure all linting tests pass, see here for how to run them
- improve the speed for get_index by avoiding some redundant zipping and unzipping
qiuwei
changed the title
qiuwei
force-pushed
the
faster_get_index
branch
from
5dba928 to
5a9f898
Compare
qiuwei
changed the title
| vals = cast("CategoricalIndex", vals) | ||
| vals = vals._data._internal_get_values() | ||
| if isinstance(vals.dtype, ExtensionDtype): | ||
| vals = vals.astype(object) |
There was a problem hiding this comment.
for e.g. dt64tz wouldnt we want to just use dt64?
| @@ -2666,6 +2684,15 @@ def _get_partial_string_timestamp_match_key(self, key): | |||
|
|
|||
| return key | |||
|
|
|||
| def _get_engine_target(self) -> np.ndarray: | |||
|
@qiuwei is this something you want to continue working on? |
@datapythonista I realize there are a lot of implementations depending on the current Close for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.