Skip to content

⬆️ UPGRADE: Autoupdate pre-commit config #41160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 25, 2021

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Apr 26, 2021

Base PullRequest

⬆️ UPGRADE: Autoupdate pre-commit config (#41160)

Command results

Details:
add path
/home/runner/work/_actions/technote-space/create-pr-action/v2/node_modules/npm-check-updates/bin
pip install pre-commit
Collecting pre-commit
  Downloading pre_commit-2.13.0-py2.py3-none-any.whl (190 kB)
Collecting identify>=1.0.0
  Downloading identify-2.2.5-py2.py3-none-any.whl (98 kB)
Collecting nodeenv>=0.11.1
  Using cached nodeenv-1.6.0-py2.py3-none-any.whl (21 kB)
Collecting cfgv>=2.0.0
  Downloading cfgv-3.3.0-py2.py3-none-any.whl (7.3 kB)
Collecting toml
  Using cached toml-0.10.2-py2.py3-none-any.whl (16 kB)
Collecting virtualenv>=20.0.8
  Using cached virtualenv-20.4.6-py2.py3-none-any.whl (7.2 MB)
Collecting pyyaml>=5.1
  Using cached PyYAML-5.4.1-cp39-cp39-manylinux1_x86_64.whl (630 kB)
Collecting appdirs<2,>=1.4.3
  Using cached appdirs-1.4.4-py2.py3-none-any.whl (9.6 kB)
Collecting filelock<4,>=3.0.0
  Using cached filelock-3.0.12-py3-none-any.whl (7.6 kB)
Collecting distlib<1,>=0.3.1
  Using cached distlib-0.3.1-py2.py3-none-any.whl (335 kB)
Collecting six<2,>=1.9.0
  Using cached six-1.16.0-py2.py3-none-any.whl (11 kB)
Installing collected packages: six, filelock, distlib, appdirs, virtualenv, toml, pyyaml, nodeenv, identify, cfgv, pre-commit
Successfully installed appdirs-1.4.4 cfgv-3.3.0 distlib-0.3.1 filelock-3.0.12 identify-2.2.5 nodeenv-1.6.0 pre-commit-2.13.0 pyyaml-5.4.1 six-1.16.0 toml-0.10.2 virtualenv-20.4.6

stderr:

WARNING: You are using pip version 21.1.1; however, version 21.1.2 is available.
You should consider upgrading via the '/opt/hostedtoolcache/Python/3.9.5/x64/bin/python -m pip install --upgrade pip' command.
pre-commit autoupdate || (exit 0);
Updating https://github.com/MarcoGorelli/absolufy-imports ... already up to date.
Updating https://github.com/python/black ... updating 20.8b1 -> 21.5b1.
Updating https://github.com/codespell-project/codespell ... already up to date.
Updating https://github.com/pre-commit/pre-commit-hooks ... updating v3.4.0 -> v4.0.1.
Updating https://github.com/cpplint/cpplint ... [INFO] Initializing environment for https://github.com/cpplint/cpplint.
updating f7061b1 -> 1.5.5.
Updating https://gitlab.com/pycqa/flake8 ... already up to date.
Updating https://github.com/PyCQA/isort ... already up to date.
Updating https://github.com/asottile/pyupgrade ... [INFO] Initializing environment for https://github.com/asottile/pyupgrade.
updating v2.12.0 -> v2.18.1.
Updating https://github.com/pre-commit/pygrep-hooks ... already up to date.
Updating https://github.com/asottile/yesqa ... updating v1.2.2 -> v1.2.3.
pre-commit run -a || (exit 0);
[INFO] Installing environment for https://github.com/cpplint/cpplint.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
[INFO] Installing environment for https://github.com/asottile/pyupgrade.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
absolufy-imports...............................................................................Passed
black..........................................................................................Failed
- hook id: black
- files were modified by this hook

reformatted pandas/_config/config.py
reformatted pandas/_libs/arrays.pyi
reformatted pandas/_libs/algos.pyi
reformatted pandas/_libs/groupby.pyi
reformatted pandas/_libs/index.pyi
reformatted pandas/_libs/internals.pyi
reformatted pandas/_libs/hashtable.pyi
reformatted pandas/_libs/join.pyi
reformatted pandas/_libs/ops.pyi
reformatted pandas/_libs/parsers.pyi
reformatted pandas/_libs/reshape.pyi
reformatted pandas/_libs/testing.pyi
reformatted pandas/_libs/tslib.pyi
reformatted pandas/_libs/tslibs/ccalendar.pyi
reformatted pandas/_libs/tslibs/conversion.pyi
reformatted pandas/_libs/lib.pyi
reformatted pandas/_libs/tslibs/dtypes.pyi
reformatted pandas/_libs/tslibs/fields.pyi
reformatted pandas/_libs/tslibs/parsing.pyi
reformatted pandas/_libs/tslibs/nattype.pyi
reformatted pandas/_libs/tslibs/strptime.pyi
reformatted pandas/_libs/tslibs/timedeltas.pyi
reformatted pandas/_libs/tslibs/period.pyi
reformatted pandas/_libs/tslibs/timezones.pyi
reformatted pandas/_libs/tslibs/tzconversion.pyi
reformatted pandas/_libs/tslibs/vectorized.pyi
reformatted pandas/_libs/tslibs/timestamps.pyi
reformatted pandas/_libs/window/indexers.pyi
reformatted pandas/_libs/window/aggregations.pyi
reformatted pandas/_libs/writers.pyi
reformatted pandas/_testing/__init__.py
reformatted pandas/conftest.py
reformatted pandas/core/algorithms.py
reformatted pandas/core/apply.py
reformatted pandas/core/arrays/categorical.py
reformatted pandas/core/arrays/masked.py
reformatted pandas/core/arrays/sparse/scipy_sparse.py
reformatted pandas/core/computation/expressions.py
reformatted pandas/core/computation/expr.py
reformatted pandas/core/computation/pytables.py
reformatted pandas/core/dtypes/common.py
reformatted pandas/core/dtypes/dtypes.py
reformatted pandas/core/dtypes/cast.py
reformatted pandas/core/groupby/ops.py
reformatted pandas/core/generic.py
reformatted pandas/core/indexes/category.py
reformatted pandas/core/indexes/range.py
reformatted pandas/core/indexes/multi.py
reformatted pandas/core/internals/array_manager.py
reformatted pandas/core/internals/blocks.py
reformatted pandas/core/internals/managers.py
reformatted pandas/core/nanops.py
reformatted pandas/core/ops/__init__.py
reformatted pandas/core/reshape/tile.py
reformatted pandas/core/reshape/merge.py
reformatted pandas/io/formats/format.py
reformatted pandas/io/parquet.py
reformatted pandas/io/parsers/readers.py
reformatted pandas/io/sas/sas_xport.py
reformatted pandas/io/sql.py
reformatted pandas/io/pytables.py
reformatted pandas/io/stata.py
reformatted pandas/tests/arithmetic/test_period.py
reformatted pandas/tests/base/test_constructors.py
reformatted pandas/tests/dtypes/test_common.py
reformatted pandas/tests/extension/base/reduce.py
reformatted pandas/tests/frame/methods/test_clip.py
reformatted pandas/tests/generic/test_generic.py
reformatted pandas/tests/generic/test_label_or_level_utils.py
reformatted pandas/tests/indexing/common.py
reformatted pandas/tests/indexing/test_coercion.py
reformatted pandas/tests/indexing/test_indexing.py
reformatted pandas/tests/internals/test_internals.py
reformatted pandas/tests/io/generate_legacy_storage_files.py
reformatted pandas/tests/io/pytables/common.py
reformatted pandas/tests/io/pytables/conftest.py
reformatted pandas/tests/plotting/frame/test_frame.py
reformatted pandas/tests/plotting/test_misc.py
reformatted pandas/tests/resample/test_base.py
reformatted pandas/tests/resample/test_deprecated.py
reformatted pandas/tests/reshape/merge/test_merge_asof.py
reformatted pandas/tests/series/methods/test_clip.py
reformatted pandas/tests/test_multilevel.py
All done! ✨ 🍰 ✨
83 files reformatted, 1290 files left unchanged.

codespell......................................................................................Passed
Debug Statements (Python)......................................................................Passed
Fix End of Files...............................................................................Passed
Trim Trailing Whitespace.......................................................................Passed
cpplint........................................................................................Passed
flake8.........................................................................................Passed
flake8 (cython)................................................................................Passed
flake8 (cython template).......................................................................Passed
isort..........................................................................................Passed
pyupgrade......................................................................................Failed
- hook id: pyupgrade
- exit code: 1
- files were modified by this hook

Rewriting doc/sphinxext/announce.py
Rewriting pandas/io/pytables.py
Rewriting pandas/tests/io/parser/test_c_parser_only.py
Rewriting pandas/tests/generic/test_series.py
Rewriting pandas/util/_decorators.py
Rewriting pandas/core/reshape/merge.py
Rewriting pandas/_config/config.py
Rewriting pandas/tests/io/parser/test_multi_thread.py
Rewriting pandas/core/reshape/tile.py
Rewriting pandas/io/formats/latex.py
Rewriting pandas/io/html.py
Rewriting pandas/tests/io/parser/test_skiprows.py
Rewriting pandas/tests/generic/test_frame.py
Rewriting pandas/tests/reshape/test_util.py
Rewriting pandas/io/formats/excel.py

rst ``code`` is two backticks..................................................................Passed
rst directives end with two colons.............................................................Passed
rst ``inline code`` next to normal text........................................................Passed
Strip unnecessary `# noqa`s....................................................................Passed
flake8-rst.....................................................................................Passed
Unwanted patterns..............................................................................Passed
Generate pip dependency from conda.............................................................Passed
Check flake8 version is synced across flake8, yesqa, and environment.yml.......................Passed
Validate correct capitalization among titles in documentation..................................Passed
Import pandas.array as pd_array in core........................................................Passed
Use bool_t instead of bool in pandas/core/generic.py...........................................Passed

Changed files

Changed 95 files:
  • .pre-commit-config.yaml
  • doc/sphinxext/announce.py
  • pandas/_config/config.py
  • pandas/_libs/algos.pyi
  • pandas/_libs/arrays.pyi
  • pandas/_libs/groupby.pyi
  • pandas/_libs/hashtable.pyi
  • pandas/_libs/index.pyi
  • pandas/_libs/internals.pyi
  • pandas/_libs/join.pyi
  • pandas/_libs/lib.pyi
  • pandas/_libs/ops.pyi
  • pandas/_libs/parsers.pyi
  • pandas/_libs/reshape.pyi
  • pandas/_libs/testing.pyi
  • pandas/_libs/tslib.pyi
  • pandas/_libs/tslibs/ccalendar.pyi
  • pandas/_libs/tslibs/conversion.pyi
  • pandas/_libs/tslibs/dtypes.pyi
  • pandas/_libs/tslibs/fields.pyi
  • pandas/_libs/tslibs/nattype.pyi
  • pandas/_libs/tslibs/parsing.pyi
  • pandas/_libs/tslibs/period.pyi
  • pandas/_libs/tslibs/strptime.pyi
  • pandas/_libs/tslibs/timedeltas.pyi
  • pandas/_libs/tslibs/timestamps.pyi
  • pandas/_libs/tslibs/timezones.pyi
  • pandas/_libs/tslibs/tzconversion.pyi
  • pandas/_libs/tslibs/vectorized.pyi
  • pandas/_libs/window/aggregations.pyi
  • pandas/_libs/window/indexers.pyi
  • pandas/_libs/writers.pyi
  • pandas/_testing/init.py
  • pandas/conftest.py
  • pandas/core/algorithms.py
  • pandas/core/apply.py
  • pandas/core/arrays/categorical.py
  • pandas/core/arrays/masked.py
  • pandas/core/arrays/sparse/scipy_sparse.py
  • pandas/core/computation/expr.py
  • pandas/core/computation/expressions.py
  • pandas/core/computation/pytables.py
  • pandas/core/dtypes/cast.py
  • pandas/core/dtypes/common.py
  • pandas/core/dtypes/dtypes.py
  • pandas/core/generic.py
  • pandas/core/groupby/ops.py
  • pandas/core/indexes/category.py
  • pandas/core/indexes/multi.py
  • pandas/core/indexes/range.py
  • pandas/core/internals/array_manager.py
  • pandas/core/internals/blocks.py
  • pandas/core/internals/managers.py
  • pandas/core/nanops.py
  • pandas/core/ops/init.py
  • pandas/core/reshape/merge.py
  • pandas/core/reshape/tile.py
  • pandas/io/formats/excel.py
  • pandas/io/formats/format.py
  • pandas/io/formats/latex.py
  • pandas/io/html.py
  • pandas/io/parquet.py
  • pandas/io/parsers/readers.py
  • pandas/io/pytables.py
  • pandas/io/sas/sas_xport.py
  • pandas/io/sql.py
  • pandas/io/stata.py
  • pandas/tests/arithmetic/test_period.py
  • pandas/tests/base/test_constructors.py
  • pandas/tests/dtypes/test_common.py
  • pandas/tests/extension/base/reduce.py
  • pandas/tests/frame/methods/test_clip.py
  • pandas/tests/generic/test_frame.py
  • pandas/tests/generic/test_generic.py
  • pandas/tests/generic/test_label_or_level_utils.py
  • pandas/tests/generic/test_series.py
  • pandas/tests/indexing/common.py
  • pandas/tests/indexing/test_coercion.py
  • pandas/tests/indexing/test_indexing.py
  • pandas/tests/internals/test_internals.py
  • pandas/tests/io/generate_legacy_storage_files.py
  • pandas/tests/io/parser/test_c_parser_only.py
  • pandas/tests/io/parser/test_multi_thread.py
  • pandas/tests/io/parser/test_skiprows.py
  • pandas/tests/io/pytables/common.py
  • pandas/tests/io/pytables/conftest.py
  • pandas/tests/plotting/frame/test_frame.py
  • pandas/tests/plotting/test_misc.py
  • pandas/tests/resample/test_base.py
  • pandas/tests/resample/test_deprecated.py
  • pandas/tests/reshape/merge/test_merge_asof.py
  • pandas/tests/reshape/test_util.py
  • pandas/tests/series/methods/test_clip.py
  • pandas/tests/test_multilevel.py
  • pandas/util/_decorators.py

:octocat: Repo | 📝 Issues | 🏬 Marketplace

@MarcoGorelli MarcoGorelli reopened this Apr 26, 2021
@jreback jreback added the Code Style Code style, linting, code_checks label Apr 26, 2021
@jreback
Copy link
Contributor

jreback commented Apr 26, 2021

like the doc-string changes. the rest i guess are fine as long as they are automatic?. cc @jbrockmendel

Copy link
Member

@simonjayhawkins simonjayhawkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i've merged a PR adding a new pyi file this morning. will probably need to merge master

def nancorr_spearman(
mat: np.ndarray, # ndarray[float64_t, ndim=2]
minp: int = 1,
) -> np.ndarray: # np.ndarray[np.float64, ndim=2]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the comment's gone.

np.ndarray, # np.ndarray[np.int64]
np.ndarray, # np.ndarray[np.int64]
]: ...
) -> tuple[np.ndarray, np.ndarray,]: ... # np.ndarray[np.int64] # np.ndarray[np.int64]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not a big deal, but this is marginally less obvious what the comment is referring to

]: ...


) -> tuple[int, int,]: ... # int64_t
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is ambiguous what the int64_t comment is referring to

@MarcoGorelli
Copy link
Member

the rest i guess are fine as long as they are automatic?

I didn't run anything here, this is just the latest release of black - I too like the new docstring formatting, but it looks like some of the comments might need fixing up manually, will get back to this

@github-actions github-actions bot force-pushed the create-pr-action/pre-commit-config-update-0 branch 2 times, most recently from 70aa9e6 to 6a271a2 Compare May 10, 2021 07:13
@github-actions github-actions bot force-pushed the create-pr-action/pre-commit-config-update-0 branch from 6a271a2 to 709a69c Compare May 17, 2021 07:14
@github-actions github-actions bot force-pushed the create-pr-action/pre-commit-config-update-0 branch from 709a69c to ea37243 Compare May 24, 2021 07:17
@pep8speaks
Copy link

pep8speaks commented May 24, 2021

Hello @github-actions[bot]! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-05-25 08:24:42 UTC

@MarcoGorelli MarcoGorelli force-pushed the create-pr-action/pre-commit-config-update-0 branch from ea37243 to de578bd Compare May 25, 2021 08:24
@MarcoGorelli MarcoGorelli added this to the 1.3 milestone May 25, 2021
@MarcoGorelli
Copy link
Member

leaving the black update out of this for now, but merging so pandas gets the other updates

@MarcoGorelli MarcoGorelli merged commit 4dcdec0 into master May 25, 2021
@MarcoGorelli MarcoGorelli deleted the create-pr-action/pre-commit-config-update-0 branch May 25, 2021 20:09
TLouf pushed a commit to TLouf/pandas that referenced this pull request Jun 1, 2021
JulianWgs pushed a commit to JulianWgs/pandas that referenced this pull request Jul 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Style Code style, linting, code_checks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants