TST: Added iloc tests for casting from object to numeric dtypes for duplicate columns #41154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
isaac-chung
commented
Apr 25, 2021
•
isaac-chung
commented
- closes Unable to change dtype of a column after concat and duplicate column names #22035
- tests added / passed
- Ensure all linting tests pass, see here for how to run them
- whatsnew entry
…aacChung_issue_22035
|
Hello @isaac-chung! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2021-04-25 22:57:11 UTC |
phofl
reviewed
Apr 25, 2021
phofl
reviewed
Apr 25, 2021
|
You could install pre-commit to automatically run the linting checks before committing |
|
I assume an extended test would not fall into the "whatsnew entry", so checking it off for completeness. Is there anything I can do about the failed checks? |
no |
jreback
added
the
Indexing
|
looks fine ping on green. |
phofl
approved these changes
Apr 26, 2021
mroeschke
approved these changes
Apr 30, 2021
|
Thanks @isaac-chung! The CI failure was unrelated |
yeshsurya
pushed a commit
to yeshsurya/pandas
that referenced
this pull request
May 6, 2021
…uplicate columns (pandas-dev#41154) * TST: Added iloc tests for casting from object to numeric dtypes for duplicate columns * Added gh reference * Check df with tm.assert_frame_equal * fix spacing * parametrize over dtypes * pre-commit hooks
JulianWgs
pushed a commit
to JulianWgs/pandas
that referenced
this pull request
Jul 3, 2021
…uplicate columns (pandas-dev#41154) * TST: Added iloc tests for casting from object to numeric dtypes for duplicate columns * Added gh reference * Check df with tm.assert_frame_equal * fix spacing * parametrize over dtypes * pre-commit hooks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.