Skip to content

BUG: make sure fig is not doubled when passing by to series.hist #4113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 22, 2013
Merged

BUG: make sure fig is not doubled when passing by to series.hist #4113

merged 1 commit into from
Sep 22, 2013

Conversation

cpcloud
Copy link
Member

@cpcloud cpcloud commented Jul 3, 2013

closes #4112.

@ghost ghost assigned cpcloud Jul 3, 2013
@cpcloud
Copy link
Member Author

cpcloud commented Jul 3, 2013

@jreback any issues here?

@cpcloud
Copy link
Member Author

cpcloud commented Jul 3, 2013

if this isn't a critical bug then i would suggest we wait to really fix the issue here in 0.13

@jreback
Copy link
Contributor

jreback commented Jul 3, 2013

is kind of hacky...up 2 u

@cpcloud
Copy link
Member Author

cpcloud commented Jul 3, 2013

k let's wait then. if anyone raises a bug then can show them how to put it into a frame and do ti

@cpcloud
Copy link
Member Author

cpcloud commented Jul 9, 2013

closing...i'll raise an issue.

@cpcloud cpcloud closed this Jul 9, 2013
@cpcloud cpcloud deleted the double-fig-series-hist-by-fix branch July 9, 2013 14:29
@cpcloud cpcloud mentioned this pull request Jul 9, 2013
Closed
@cpcloud cpcloud restored the double-fig-series-hist-by-fix branch September 21, 2013 01:38
@cpcloud cpcloud reopened this Sep 21, 2013
@cpcloud
Copy link
Member Author

cpcloud commented Sep 21, 2013

Reopening because the plotting API will take some time to fix and double figures should not be happening in the meantime

@cpcloud
Copy link
Member Author

cpcloud commented Sep 21, 2013

@jreback ok 2 merge?

@jreback
Copy link
Contributor

jreback commented Sep 21, 2013

sure...if you think ready...i don't really get into the plotting too much

@cpcloud
Copy link
Member Author

cpcloud commented Sep 21, 2013

alright let me put it through the ringer with some of my god-awful plotting code and see if i find any edge cases

cpcloud added a commit that referenced this pull request Sep 22, 2013
@cpcloud
Merge pull request #4113 from cpcloud/double-fig-series-hist-by-fix
cdba224 
BUG: make sure fig is not doubled when passing by to series.hist
@cpcloud cpcloud merged commit cdba224 into pandas-dev:master Sep 22, 2013
@cpcloud cpcloud deleted the double-fig-series-hist-by-fix branch September 22, 2013 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@cpcloud cpcloud

Labels
None yet
Projects
None yet
Milestone
0.13
Development

Successfully merging this pull request may close these issues.

BUG: double figure when passing by to Series.hist
2 participants
@cpcloud @jreback