ENH: Styler.text_gradient: easy extension alternative to .background_gradient
#41098
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # pandas/io/formats/style.py
attack68
changed the title
Styler.text_gradient: easy extension alternative to .background_gradient
jreback
requested changes
May 3, 2021
pandas/io/formats/style.py
Outdated
| Parameters | ||
| ---------- | ||
| cmap : str or colormap | ||
| Matplotlib colormap. |
There was a problem hiding this comment.
these match the kwargs for background_gradient? if not why not
There was a problem hiding this comment.
can you use a shared doc-string?
There was a problem hiding this comment.
yes they all match its the same signature. Can you use a shared doc string even if the short summary/ extended summary part, and the examples are different? I've never used a shared doc string.. any tips where one is used that I can lookup and copy?
There was a problem hiding this comment.
nevermind.. i figured it out and made the changes.
# Conflicts: # pandas/io/formats/style.py
jreback
approved these changes
May 21, 2021
|
lgtm. can you rebase one more time and ping on green. also pls update the styler docs as a followon. |
|
@jreback pinging green now. |
|
Thanks @attack68 |
TLouf
pushed a commit
to TLouf/pandas
that referenced
this pull request
Jun 1, 2021
JulianWgs
pushed a commit
to JulianWgs/pandas
that referenced
this pull request
Jul 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is minor code alteration to the
_background_gradientfunction that permits a text-only coloring version, i.e.Styler.text_gradient.This could alternatively be performed with a
text_only=Truekeyword addition toStyler.background_gradientexisting method, but it seemed dissimilar enough to merit its own method (and avoid adding more kwargs).