-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
ENH: check for string and convert to list in DataFrame.dropna subset argument #41022
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
rhshadrach
merged 26 commits into
pandas-dev:master
from
erfannariman:dropna-accept-string
Oct 18, 2021
Merged
Changes from 22 commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
6afcbcd
check for string and convert to list
erfannariman 86d2cd8
add test for missing key in axis
erfannariman 03d3e0d
add match pytest
erfannariman f7a1847
add whatsnew entry
erfannariman 0326c7a
add correct typing and checks
erfannariman 63a78ef
rename typing in docstring:
erfannariman 93fb0b3
fix typo whatsnew
erfannariman 103bd35
use is list like
erfannariman 365c6c0
fix tests
erfannariman cace369
fix typing
erfannariman 66d447d
use pandas typing
erfannariman 7be5fe7
more clear whatsnew entry
erfannariman 1dd0a64
move whatsnew entry to 1.3
erfannariman 56ef81e
revert whatsnew 1.2.5 to master
erfannariman ae633cf
merge master and fix conflicts, plus add gh issue to whatsnew
erfannariman 4b905e5
use com.maybe_make_list
erfannariman c585c8f
remove is list like
erfannariman 1d5f208
remove list like
erfannariman 2bf5ac3
move whatsnew entry to 1.4
erfannariman 9ea97ff
revert to is_list_like and add test with np.array
erfannariman d09c6ba
remove blank line
erfannariman c09d147
use basic indexing instead of np.compress
erfannariman e95200b
merge master
erfannariman df5ca75
remove dot
erfannariman 17fe9bc
use list instead of tuple
erfannariman b471701
Merge branch 'master' into dropna-accept-string
erfannariman File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -129,6 +129,7 @@ Other enhancements | |
- :meth:`DataFrame.__pos__`, :meth:`DataFrame.__neg__` now retain ``ExtensionDtype`` dtypes (:issue:`43883`) | ||
- The error raised when an optional dependency can't be imported now includes the original exception, for easier investigation (:issue:`43882`) | ||
- Added :meth:`.ExponentialMovingWindow.sum` (:issue:`13297`) | ||
- :meth:`DataFrame.dropna` now accepts a single label as ``subset`` along with array-like. (:issue:`41021`) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. No period at the end |
||
|
||
.. --------------------------------------------------------------------------- | ||
|
||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you revert this change