Skip to content

BUG: isna not returning copy for MaskedArray #41020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 20, 2021
Merged

BUG: isna not returning copy for MaskedArray #41020

merged 3 commits into from
Apr 20, 2021

Conversation

mzeitlin11
Copy link
Member

Think further improvements like zero-copy access fall under #34873, so #40935 can be closed.

@mzeitlin11 mzeitlin11 added Bug NA - MaskedArrays Related to pd.NA and nullable extension arrays labels Apr 18, 2021
jorisvandenbossche
jorisvandenbossche approved these changes Apr 20, 2021
View reviewed changes
Copy link
Member

@jorisvandenbossche jorisvandenbossche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@jorisvandenbossche jorisvandenbossche added this to the 1.3 milestone Apr 20, 2021
@jreback jreback merged commit 770918a into pandas-dev:master Apr 20, 2021
@jreback
Copy link
Contributor

jreback commented Apr 20, 2021

thanks @mzeitlin11

@mzeitlin11 mzeitlin11 deleted the isna_copy branch April 20, 2021 13:04
yeshsurya pushed a commit to yeshsurya/pandas that referenced this pull request Apr 21, 2021
@mzeitlin11 @yeshsurya
BUG: isna not returning copy for MaskedArray (pandas-dev#41020)
85cadf8
yeshsurya pushed a commit to yeshsurya/pandas that referenced this pull request May 6, 2021
@mzeitlin11 @yeshsurya
BUG: isna not returning copy for MaskedArray (pandas-dev#41020)
bd35676
JulianWgs pushed a commit to JulianWgs/pandas that referenced this pull request Jul 3, 2021
@mzeitlin11 @JulianWgs
BUG: isna not returning copy for MaskedArray (pandas-dev#41020)
93a6bf8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorisvandenbossche jorisvandenbossche jorisvandenbossche approved these changes

Assignees
No one assigned
Labels
Bug NA - MaskedArrays Related to pd.NA and nullable extension arrays
Projects
None yet
Milestone
1.3
Development

Successfully merging this pull request may close these issues.

API: Should isna return a copy for nullable types?
3 participants
@mzeitlin11 @jreback @jorisvandenbossche