Skip to content

BUG: Fix Dataframe constructor missing sql column names (#40682) #41005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 5 commits into from
Closed

BUG: Fix Dataframe constructor missing sql column names (#40682) #41005

wants to merge 5 commits into from

Conversation

jnchngc
Copy link

@jnchngc jnchngc commented Apr 17, 2021 •
edited
Loading

…ames

@pep8speaks
Copy link

pep8speaks commented Apr 17, 2021 •
edited
Loading

Hello @jnchngc! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-04-23 21:46:40 UTC

jreback
jreback requested changes Apr 26, 2021
View reviewed changes
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you would always need to start with a test

pandas/core/frame.py
@@ -669,6 +669,16 @@ def __init__(
# For data is list-like, or Iterable (will consume into list)
elif is_list_like(data):
if not isinstance(data, (abc.Sequence, ExtensionArray)):
# For data is a sqlalchemy query, extract column names
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

umm what exactly are you trying to do here?

@jreback jreback added the IO SQL to_sql, read_sql, read_sql_query label Apr 26, 2021
@github-actions
Copy link
Contributor

This pull request is stale because it has been open for thirty days with no activity. Please update or respond to this comment if you're still interested in working on this.

@github-actions github-actions bot added the Stale label Jun 25, 2021
@mzeitlin11
Copy link
Member

Thanks for contributing @jnchngc, closing as stale for now, but please ping to reopen if you'd like to continue and address comments (would also be good to avoid the added dependency here as well).

@mzeitlin11 mzeitlin11 closed this Jun 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreback jreback jreback requested changes

Assignees
No one assigned
Labels
Bug IO SQL to_sql, read_sql, read_sql_query Stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BUG: DataFrame from sqlalchemy 1.4 Query missing column headers
5 participants
@jnchngc @pep8speaks @mzeitlin11 @jreback @simonjayhawkins