Skip to content

fix: function _take_with_is_copy was defined final but overriden #41004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 19, 2021
Merged

fix: function _take_with_is_copy was defined final but overriden #41004

merged 2 commits into from
Apr 19, 2021

Conversation

ajiteshsingh
Copy link
Contributor

@ajiteshsingh ajiteshsingh commented Apr 17, 2021 •
edited by phofl
Loading

@MarcoGorelli
Copy link
Member

Thanks! Can you also add the return type to this function in series.py? Now that final is removed, that should work

@MarcoGorelli
Copy link
Member

Thanks! Can you also add the return type to this function in series.py? Now that final is removed, that should work

should just be -> Series

@MarcoGorelli MarcoGorelli added the Typing type annotations, mypy/pyright type checking label Apr 18, 2021
@MarcoGorelli MarcoGorelli added this to the 1.3 milestone Apr 19, 2021
@MarcoGorelli MarcoGorelli merged commit 8bdf3c4 into pandas-dev:master Apr 19, 2021
@MarcoGorelli
Copy link
Member

Thanks @ajiteshsingh

yeshsurya pushed a commit to yeshsurya/pandas that referenced this pull request Apr 21, 2021
@ajiteshsingh @yeshsurya
fix: function _take_with_is_copy was defined final but overriden (pan…
331fef4 
…das-dev#41004)

* fix: function _take_with_is_copy was defined final but overriden

* fix: add return type
yeshsurya pushed a commit to yeshsurya/pandas that referenced this pull request May 6, 2021
@ajiteshsingh @yeshsurya
fix: function _take_with_is_copy was defined final but overriden (pan…
6882acf 
…das-dev#41004)

* fix: function _take_with_is_copy was defined final but overriden

* fix: add return type
JulianWgs pushed a commit to JulianWgs/pandas that referenced this pull request Jul 3, 2021
@ajiteshsingh @JulianWgs
fix: function _take_with_is_copy was defined final but overriden (pan…
4e737d9 
…das-dev#41004)

* fix: function _take_with_is_copy was defined final but overriden

* fix: add return type
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcoGorelli MarcoGorelli MarcoGorelli approved these changes

@jbrockmendel jbrockmendel Awaiting requested review from jbrockmendel

Assignees
No one assigned
Labels
Typing type annotations, mypy/pyright type checking
Projects
None yet
Milestone
1.3
Development

Successfully merging this pull request may close these issues.

TYP final _take_with_is_copy is overridden in series
2 participants
@ajiteshsingh @MarcoGorelli