Skip to content

DOC: Reindexing behaviour of dataframe column-assignment missing #40985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 24 commits into from
Closed

DOC: Reindexing behaviour of dataframe column-assignment missing #40985

wants to merge 24 commits into from

Conversation

hewittk
Copy link
Contributor

@hewittk hewittk commented Apr 16, 2021 •
edited
Loading

Kiley and others added 13 commits March 19, 2021 15:42
if/else changes test
89259db
Series.between changes to inclusive boundaries
eda20a1
changes to date_range parameters
7af55a7
Changed series.between error handling to throw value error instead of…
85a33cc 
… simple print statement
changes to series.between documentation and error message
c87e240
@hewittk
Merge pull request #1 from hewittk/new-boundary-inputs
cc6b24d 
New boundary inputs
parameters as either booleans or strings
4ebfa59
@hewittk
Merge pull request #2 from hewittk/new-boundary-inputs
438f1ba 
Parameters as either booleans or strings
@mmarconi
addition of new examples in indexing.py
e81e420
Added general example of adding column using series
fc4afe6
Made examples specific to .loc[]
14fb6ab
Remove changes made from copied previous files
fce9b2d
Removed minor changes remaining from copied previous files
05277f2
@hewittk
Copy link
Contributor Author

hewittk commented Apr 16, 2021

Do we need a whatsnew entry for a documentation-only issue? If so, where and in what general format to we put it?

phofl
phofl reviewed Apr 16, 2021
View reviewed changes
@phofl
Copy link
Member

phofl commented Apr 16, 2021

Don't think we need a whatsnew, you can not use closes if you are fixing part of the issue, because this would close the issue. E.g. your number is wrong, you are referencing the pr

@jreback jreback changed the title Issue39845 column indexing DOC: Reindexing behaviour of dataframe column-assignment missing Apr 19, 2021
jreback
jreback requested changes Apr 19, 2021
View reviewed changes
@jreback jreback added Docs Indexing Related to indexing on series/frames, not to indexes themselves labels Apr 19, 2021
@hewittk hewittk requested review from phofl and jreback April 24, 2021 17:39
jreback
jreback requested changes May 5, 2021
View reviewed changes
@github-actions
Copy link
Contributor

github-actions bot commented Jun 5, 2021

This pull request is stale because it has been open for thirty days with no activity. Please update or respond to this comment if you're still interested in working on this.

@github-actions github-actions bot added the Stale label Jun 5, 2021
@hewittk
Copy link
Contributor Author

hewittk commented Jun 7, 2021

This pull request is stale because it has been open for thirty days with no activity. Please update or respond to this comment if you're still interested in working on this.

I apologize for the lack of activity. I was very busy with finals and will be working towards closing this pull request in the coming days.

@pep8speaks
Copy link

pep8speaks commented Jun 9, 2021 •
edited
Loading

Hello @hewittk! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-06-09 21:14:12 UTC

@hewittk hewittk requested a review from jreback June 9, 2021 21:17
@lithomas1 lithomas1 removed the Stale label Jun 10, 2021
@github-actions
Copy link
Contributor

This pull request is stale because it has been open for thirty days with no activity. Please update or respond to this comment if you're still interested in working on this.

@github-actions github-actions bot added the Stale label Jul 11, 2021
mroeschke
mroeschke reviewed Aug 17, 2021
View reviewed changes
pandas/core/indexing.py
@@ -287,6 +287,10 @@ def loc(self) -> _LocIndexer:
- An alignable boolean Series. The index of the key will be aligned before
masking.
- An alignable Index. The Index of the returned selection will be the input.

.. warning:: Preferred syntax to assign a column: `df[]` instead of
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this true? I didn't find note of this in the original issue?

mroeschke
mroeschke reviewed Aug 17, 2021
View reviewed changes
pandas/core/indexing.py
@@ -388,6 +392,9 @@ def loc(self) -> _LocIndexer:

**Setting values**

.. warning:: Preferred syntax to assign a column: `df['shield']`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same

@mroeschke
Copy link
Member

Sorry this went un-reviewed for a while. Could you merge master again to this branch?

@mroeschke
Copy link
Member

Thanks for the PR, but it appears to have gone stale. Let us know if you're still interested in working on this and we can reopen. Closing.

@mroeschke mroeschke closed this Sep 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke left review comments

@phofl phofl phofl approved these changes

@jreback jreback Awaiting requested review from jreback

Assignees
No one assigned
Labels
Docs Indexing Related to indexing on series/frames, not to indexes themselves Stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@hewittk @phofl @pep8speaks @mroeschke @jreback @lithomas1 @mmarconi