-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
TYP: Signature of "reindex" incompatible with supertype "NDFrame" #40984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 3 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
fd7f62f
align reindex with supertype
MarcoGorelli 57c6312
align reindex with supertype
MarcoGorelli 9f9c464
:label:
MarcoGorelli bc08d18
tuple unpacking
MarcoGorelli 61e03b7
quote DataFrame
MarcoGorelli c5a8791
Merge remote-tracking branch 'upstream/master' into align-reindex
MarcoGorelli aff30c7
cast -> type: ignore
MarcoGorelli e250a9f
Merge remote-tracking branch 'upstream/master' into align-reindex
MarcoGorelli b09b7bc
add test with no positional arguments
MarcoGorelli 245eee2
add test with no positional arguments
MarcoGorelli 8bf72f2
Merge remote-tracking branch 'upstream/master' into align-reindex
MarcoGorelli c01949e
Merge remote-tracking branch 'upstream/master' into align-reindex
MarcoGorelli b79730e
Merge remote-tracking branch 'upstream/master' into align-reindex
MarcoGorelli 6a11666
remove now unnecessary type: ignore
MarcoGorelli d394e92
Merge remote-tracking branch 'upstream/master' into align-reindex
MarcoGorelli 9907085
Merge remote-tracking branch 'upstream/master' into align-reindex
MarcoGorelli e77e919
Merge remote-tracking branch 'upstream/master' into align-reindex
MarcoGorelli File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
x.reindex(col_names, copy=False)
was previously revealed to be of typeAny
. Now that it's typed, the result ofconcat
isFrame | Series
, so the cast is necessaryThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
presumably at some point we'll overload concat s.t. axis=1 returns DataFrame, at which point this cast will be unnecessary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, exactly!