TYP: Signature of "rename" incompatible with supertype "NDFrame" #40979
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcoGorelli
commented
Apr 16, 2021
|
can we remove rewrite_axis_style_signature from DataFrame.rename? |
I haven't yet made sense fo what |
jreback
requested changes
Apr 28, 2021
|
This pull request is stale because it has been open for thirty days with no activity. Please update or respond to this comment if you're still interested in working on this. |
|
still working? |
|
Yup, ready for review |
jreback
requested changes
Oct 11, 2021
|
needs rebase |
jreback
approved these changes
Nov 26, 2021
|
thanks @MarcoGorelli i realize now why this is convoluted, will be glad to remove this in 2.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@WillAyd this should still be backwards compatible, it just makes the signature compatible with its parent's