Skip to content

TYP add some missing types to series #40975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 16, 2021
Merged

TYP add some missing types to series #40975

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions pandas/core/series.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1019,7 +1019,7 @@ def _get_value(self, label, takeable: bool = False):
loc = self.index.get_loc(label)
return self.index._get_values_for_loc(self, loc, label)

def __setitem__(self, key, value):
def __setitem__(self, key, value) -> None:
key = com.apply_if_callable(key, self)
cacher_needs_updating = self._check_is_chained_assignment_possible()

Expand Down Expand Up @@ -1058,7 +1058,7 @@ def __setitem__(self, key, value):
if cacher_needs_updating:
self._maybe_update_cacher()

def _set_with_engine(self, key, value):
def _set_with_engine(self, key, value) -> None:
# fails with AttributeError for IntervalIndex
loc = self.index._engine.get_loc(key)
# error: Argument 1 to "validate_numeric_casting" has incompatible type
Expand Down Expand Up @@ -1094,15 +1094,15 @@ def _set_with(self, key, value):
else:
self.loc[key] = value

def _set_labels(self, key, value):
def _set_labels(self, key, value) -> None:
key = com.asarray_tuplesafe(key)
indexer: np.ndarray = self.index.get_indexer(key)
mask = indexer == -1
if mask.any():
raise KeyError(f"{key[mask]} not in index")
self._set_values(indexer, value)

def _set_values(self, key, value):
def _set_values(self, key, value) -> None:
if isinstance(key, Series):
key = key._values

Expand Down