Clarify docs for MultiIndex drops and levels #40953
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
requested changes
Apr 20, 2021
pandas/core/frame.py
Outdated
| @@ -4749,7 +4749,7 @@ def drop( | |||
| Remove rows or columns by specifying label names and corresponding | |||
| axis, or by specifying directly index or column names. When using a | |||
| multi-index, labels on different levels can be removed by specifying | |||
| the level. | |||
| the level. The now-unused levels remain in the MultiIndex._levels attribute. | |||
There was a problem hiding this comment.
I think it would actually be better to just link to https://pandas.pydata.org/pandas-docs/stable/user_guide/advanced.html#defined-levels as you did in the original issue. I don't think it's great to advertise "private" attributes in the docs.
mroeschke
approved these changes
Apr 20, 2021
|
thanks @phofl |
yeshsurya
pushed a commit
to yeshsurya/pandas
that referenced
this pull request
Apr 21, 2021
JulianWgs
pushed a commit
to JulianWgs/pandas
that referenced
this pull request
Jul 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did something like this in the past but this got lost back then between prs.