REF: handle dtype dispatch in libhashtable, share Vector/Hashtable code #40944
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jbrockmendel
commented
Apr 14, 2021
jbrockmendel
commented
- closes #xxxx
- tests added / passed
- Ensure all linting tests pass, see here for how to run them
- whatsnew entry
mzeitlin11
reviewed
Apr 14, 2021
| elif htfunc_t is complex128_t: | ||
| return value_count_complex128(values, dropna) | ||
| elif htfunc_t is complex64_t: | ||
| return value_count_complex64(values, dropna) |
There was a problem hiding this comment.
Can't wait for the arrival of pattern matching in python :)
|
can you rebase (havne't looked yet) |
jreback
added
Dtype Conversions
|
ok looks fine, any perf diffs? (maybe expect small marginal improvements) |
i expect it to be a wash |
jreback
approved these changes
May 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.