Skip to content

BUG: Dataframe mask method does not work properly with pd.StringDtype() #40941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Apr 16, 2021
Merged

BUG: Dataframe mask method does not work properly with pd.StringDtype() #40941

merged 8 commits into from
Apr 16, 2021

Conversation

DriesSchaumont
Copy link
Member

@DriesSchaumont DriesSchaumont commented Apr 14, 2021 •
edited
Loading

@DriesSchaumont DriesSchaumont changed the title Add test and attempted fix. BUG: Dataframe mask method does not work properly with pd.StringDtype() Apr 14, 2021
@DriesSchaumont DriesSchaumont marked this pull request as ready for review April 15, 2021 09:14
@jreback jreback added Indexing Related to indexing on series/frames, not to indexes themselves Strings String extension data type and string data labels Apr 15, 2021
@jreback jreback added this to the 1.3 milestone Apr 16, 2021
@DriesSchaumont DriesSchaumont requested a review from jreback April 16, 2021 16:06
@jreback jreback merged commit d19a677 into pandas-dev:master Apr 16, 2021
@jreback
Copy link
Contributor

jreback commented Apr 16, 2021

thanks @DriesSchaumont

@DriesSchaumont DriesSchaumont deleted the fix-40824 branch April 16, 2021 16:16
yeshsurya pushed a commit to yeshsurya/pandas that referenced this pull request Apr 21, 2021
@DriesSchaumont @yeshsurya
BUG: Dataframe mask method does not work properly with pd.StringDtype…
344d52a 
…() (pandas-dev#40941)
yeshsurya pushed a commit to yeshsurya/pandas that referenced this pull request May 6, 2021
@DriesSchaumont @yeshsurya
BUG: Dataframe mask method does not work properly with pd.StringDtype…
e56ee2e 
…() (pandas-dev#40941)
JulianWgs pushed a commit to JulianWgs/pandas that referenced this pull request Jul 3, 2021
@DriesSchaumont @JulianWgs
BUG: Dataframe mask method does not work properly with pd.StringDtype…
6991b2a 
…() (pandas-dev#40941)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreback jreback jreback approved these changes

Assignees
No one assigned
Labels
Indexing Related to indexing on series/frames, not to indexes themselves Strings String extension data type and string data
Projects
None yet
Milestone
1.3
Development

Successfully merging this pull request may close these issues.

BUG: Dataframe mask method does not work properly with pd.StringDtype()
2 participants
@DriesSchaumont @jreback