Skip to content

CLN: preliminary refactor before Styler.highlight_quantile #40928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 13, 2021
Merged

CLN: preliminary refactor before Styler.highlight_quantile #40928

merged 2 commits into from
Apr 13, 2021

Conversation

attack68
Copy link
Contributor

The current structure is:

def highlight_between:
    def f:
        return x
    return self.apply(f)

So that Styler.highlight_quantile can reuse code this PR refactors the above to:

def highlight_between:
    return self.apply(_new_name)

def _new_name:
    return x

@attack68 attack68 changed the title CLN: preliminary refactor before Styler.highlight_between CLN: preliminary refactor before Styler.highlight_quantile Apr 13, 2021
@jreback jreback added Refactor Internal refactoring of code Styler conditional formatting using DataFrame.style labels Apr 13, 2021
@jreback jreback added this to the 1.3 milestone Apr 13, 2021
@jreback
Copy link
Contributor

jreback commented Apr 13, 2021

sure

@jreback jreback merged commit 6967785 into pandas-dev:master Apr 13, 2021
@attack68 attack68 deleted the highlight_quantile_preliminary branch April 14, 2021 05:08
JulianWgs pushed a commit to JulianWgs/pandas that referenced this pull request Jul 3, 2021
@attack68 @JulianWgs
restructure highlight_between (pandas-dev#40928)
3e5f1ea 
Co-authored-by: JHM Darbyshire (iMac) <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Refactor Internal refactoring of code Styler conditional formatting using DataFrame.style
Projects
None yet
Milestone
1.3
Development

Successfully merging this pull request may close these issues.
2 participants
@attack68 @jreback