ENH: Nullable integer/boolean/floating support in lib inferencing functions #40914
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lithomas1
added
Enhancement
NA - MaskedArrays
jreback
requested changes
Apr 13, 2021
| BooleanArray( | ||
| np.array([True, False], dtype="bool"), np.array([False, True]) | ||
| ), | ||
| ), |
There was a problem hiding this comment.
do we have tests for maybe_convert_bool already? can you integrate with those
There was a problem hiding this comment.
No. maybe_convert_bool is only used by python parser.
jreback
requested changes
Apr 22, 2021
lithomas1
commented
Apr 27, 2021
| @@ -676,7 +676,7 @@ def _infer_types(self, values, na_values, try_num_bool=True): | |||
| if try_num_bool and is_object_dtype(values.dtype): | |||
| # exclude e.g DatetimeIndex here | |||
| try: | |||
| result = lib.maybe_convert_numeric(values, na_values, False) | |||
| result, _ = lib.maybe_convert_numeric(values, na_values, False) | |||
There was a problem hiding this comment.
This will be addressed in #40687, the main PR.
jreback
approved these changes
Apr 30, 2021
jreback
requested changes
Apr 30, 2021
|
@jreback Not sure I follow here. I'm just following
so that would be tuple[np.ndarray, np.ndarray | None]. We are not returning the masked EA directly since it is an anti-pattern. |
jreback
approved these changes
May 5, 2021
|
thanks @lithomas1 if you wouldn't mind doing a PR to add doc-strings to the maybe_* routines, the issue is the Returns is now not super obvious. thanks. |
|
Thanks a lot @lithomas1 ! |
JulianWgs
pushed a commit
to JulianWgs/pandas
that referenced
this pull request
Jul 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Precursor for #40687