Add type to arg of series/drop-duplicates #40910
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@MarcoGorelli if you can have a look, I don't think I can assign the PR :) |
MarcoGorelli
suggested changes
Apr 13, 2021
There was a problem hiding this comment.
Nice, thanks @olgarithms !
Can we be more precise? How about
keep: Literal['first', 'last', False]where Literal will have to be imported as
if TYPE_CHECKING:
from typing import Literal(because it's not available in py37)
you can define this in pandas._typing as we use keep in a number of places |
|
@olgarithms can you address comments |
|
Hi, yes! I am going to work on it this weekend! |
|
@olgarithms closing to clear queue. ping if you would like to continue working in this, and i'll reopen. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed in #40867 that keep didn't specify a type, so adding it here.