Skip to content

BUG: pass sharex and sharey in grouped_hist #4091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 1, 2013
Merged

BUG: pass sharex and sharey in grouped_hist #4091

merged 1 commit into from
Jul 1, 2013
+38 −1

Conversation

cpcloud
Copy link
Member

@cpcloud cpcloud commented Jul 1, 2013

closes #4089

@ghost ghost assigned cpcloud Jul 1, 2013
@cpcloud
Copy link
Member Author

cpcloud commented Jul 1, 2013

i delved into matplotlib's code to see how they test shared-ness...turns out there's a nice property for each axis and then a joined method that tells if two axes are shared. mpl ftw.

@cpcloud
Copy link
Member Author

cpcloud commented Jul 1, 2013

@fonnesbeck u want to try it out?

cpcloud added a commit that referenced this pull request Jul 1, 2013
@cpcloud
Merge pull request #4091 from cpcloud/fix-share-params-grouped-hist
cdb3b2c 
BUG: pass sharex and sharey in grouped_hist
@cpcloud cpcloud merged commit cdb3b2c into pandas-dev:master Jul 1, 2013
@cpcloud cpcloud deleted the fix-share-params-grouped-hist branch July 1, 2013 03:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@cpcloud cpcloud

Labels
None yet
Projects
None yet
Milestone
0.12
Development

Successfully merging this pull request may close these issues.

DataFrame.hist does not honor sharex or sharey set to True
1 participant
@cpcloud