DOC: whats new other section reduced
#40900
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
attack68
commented
Apr 12, 2021
attack68
commented
- closes DOC: move *most* of Other Bug Fix section #40897
doc/source/whatsnew/v1.3.0.rst
Outdated
| @@ -117,6 +117,9 @@ We provided some focused development on :class:`.Styler`, including altering met | |||
| to accept more universal CSS language for arguments, such as ``'color:red;'`` instead of | |||
| ``[('color', 'red')]`` (:issue:`39564`). This is also added to the built-in methods | |||
| to allow custom CSS highlighting instead of default background coloring (:issue:`40242`). | |||
| Enhancements to other built-in methods include extending the :meth:`.Styler.background_gradient` | |||
| method to shade elements based on a given gradient map and not be restricted only to | |||
| values in the DataFrame (:issue:`39930`). | |||
There was a problem hiding this comment.
emm, just one nitpick, is 39930 an issue?
There was a problem hiding this comment.
nah, i don't think there is sphinx for prs, if so, would suggest to use (:issue:`22727`, :issue:`28901`), instead of (:issue:`39930`). Since usually put issue numbers to track in whatsnew, the 39930 is not issue but pr, then users who check it might get confused.
There was a problem hiding this comment.
no they are the same (issue or pr), but yeah you can list all 3 (we usually list just the issues, however if the PR adds somehing non-trivial then can list that 2)
attack68
commented
Apr 12, 2021
|
thanks @attack68 |
JulianWgs
pushed a commit
to JulianWgs/pandas
that referenced
this pull request
Jul 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.