BUG: DataFrame.from_records doesn't raise proper error message when Series passed

[hasan-yaman]

• closes DataFrame.from_records fails when the argument is Series with non-default index #40429
• tests added / passed
• Ensure all linting tests pass, see here for how to run them
• whatsnew entry

[phofl]

Since this was tested, should we deprecate these cases first?

[mzeitlin11]

The docs include sequence of tuples or dicts as an input option, so continuing to support that seems fine (or at least should be deprecated). So those tests probably shouldn't be deleted.

[hasan-yaman]

Passing series will give an error and according to docs Series are not supported (#40429 ).
With the PR, pandas will continue to support sequence of tuples or dicts and it will give more appropriate error message when Series passed.

[hasan-yaman]

By the way, any suggestion to fix failing test(I think related to mypy.)?

[datapythonista]

Thanks for the contribution @hasan-yaman

I think it makes more sense if DataFrame.from_records(data=Series([1, 2, 3])) just returns data.to_frame(). The code here looks cumbersome, and likely to cause problems in the future. @jreback what do you think?

One question @hasan-yaman, why are you removing tests? I guess I'm missing something, but existing tests should be kept, and a new one passing a Series should be added. Removing or editing tests while changing existing code is dangerous.

[github-actions]

This pull request is stale because it has been open for thirty days with no activity. Please update or respond to this comment if you're still interested in working on this.

[simonjayhawkins]

@hasan-yaman can you address @datapythonista comments

[mroeschke]

Thanks for the PR, but it appears to have gone stale and needs follow up from the other reviewers. Closing, but happy to open if you're interested on continuing.