Skip to content

ARM64 parallel builds #40868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 13, 2021
Merged

ARM64 parallel builds #40868

merged 2 commits into from
Apr 13, 2021

Conversation

lithomas1
Copy link
Member

@lithomas1 lithomas1 commented Apr 10, 2021 •
edited
Loading

Seems to have gotten build from > 1 hr to ~ 38 min.

@lithomas1 lithomas1 marked this pull request as ready for review April 10, 2021 21:08
@lithomas1 lithomas1 changed the title WIP: ARM64 parallel builds ARM64 parallel builds Apr 10, 2021
@lithomas1 lithomas1 added CI Continuous Integration ARM aarch64 architecture labels Apr 10, 2021
@lithomas1 lithomas1 requested a review from jreback April 10, 2021 21:47
@jreback jreback added this to the 1.3 milestone Apr 13, 2021
@jreback jreback merged commit ad5ee33 into pandas-dev:master Apr 13, 2021
@jreback
Copy link
Contributor

jreback commented Apr 13, 2021

thanks @lithomas1 yes this looks great!

@lithomas1 lithomas1 deleted the ci-travis-arm branch April 13, 2021 16:37
@martin-g
Copy link
Contributor

Hi!
Actually this PR changed from ARM64 to AMD64. See https://travis-ci.com/github/pandas-dev/pandas and expand Build system information . There you will see OS/Arch: linux/amd64. The label "arm64-graviton2" is a known bug but Travis people don't want to fix it.

https://blog.travis-ci.com/2020-09-11-arm-on-aws, section "Quick tips" says: You have to explicitly set virt: and group: keys to invoke the AWS Graviton2 CPU. Otherwise, your builds will be routed to the Travis CI default amd64 environment.

@jreback
Copy link
Contributor

jreback commented Apr 14, 2021

wow that's a crazy bug

cc @lithomas1

martin-g added a commit to martin-g/pandas that referenced this pull request Apr 15, 2021
@martin-g
Add 'virt' and 'group' settings for arm64-graviton2
3791527 
pandas-dev#40868 tried to change from `arm64` to `arm64-graviton2` but actually changed it to `amd64` because of the missing `virt` and `group` settings, as explained at https://blog.travis-ci.com/2020-09-11-arm-on-aws, section "Quick tips"
@martin-g martin-g mentioned this pull request Apr 15, 2021
Merged
@martin-g
Copy link
Contributor

A fix is proposed with #40959

JulianWgs pushed a commit to JulianWgs/pandas that referenced this pull request Jul 3, 2021
@lithomas1 @JulianWgs
ARM64 parallel builds (pandas-dev#40868)
c1068f3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreback jreback Awaiting requested review from jreback

Assignees
No one assigned
Labels
ARM aarch64 architecture CI Continuous Integration
Projects
None yet
Milestone
1.3
Development

Successfully merging this pull request may close these issues.

CI: arm Travis build timing out
3 participants
@lithomas1 @jreback @martin-g