Skip to content

Fix bug in index.union with duplicates and not a subset of each other #40862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 14, 2021

Conversation

phofl
Copy link
Member

@phofl phofl commented Apr 9, 2021

  • tests added / passed
  • Ensure all linting tests pass, see here for how to run them

The previous fix missed one case where other has dups which are unique in self

@phofl phofl added Bug Index Related to the Index class or subclasses labels Apr 9, 2021
Copy link
Member

@jbrockmendel jbrockmendel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great, can you add this PR number to the original whatsnew entry. ping on green.

@jreback jreback added this to the 1.3 milestone Apr 13, 2021
@phofl
Copy link
Member Author

phofl commented Apr 13, 2021

@jreback greenish, failure unrelated

@jreback jreback merged commit 42c7faf into pandas-dev:master Apr 14, 2021
@jreback
Copy link
Contributor

jreback commented Apr 14, 2021

very nice @phofl

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Index Related to the Index class or subclasses
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants