-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
DEPR: Styler.where
possible deprecation
#40821
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
i would actually deprecate .applymap, as its a non-vectorized version of .where (not that this matters for Styler generally). ok can you separate out the bug fix and do the deprecation in a different PR? (where can discuss) |
my other PR #40845 fixes the bug. This one I left as the potential deprecation. |
Styler.where
bug fix and possible deprecationStyler.where
possible deprecation
# Conflicts: # pandas/io/formats/style.py # pandas/tests/io/formats/style/test_style.py
# Conflicts: # pandas/io/formats/style.py
cc @pandas-dev/pandas-core any thoughts here |
To use
To use
|
I think I agree with this. As a user I always find myself having to stop and think what |
ok thanks, yeah no harm in deprecating |
closes #40124
Proposal to deprecate the method:
Styler.where
, sinceStyler.applymap
andStyler.where
are so similar in function, and return signatures, that it is almost confusing to have 2 methods for the same thing.Note that
Styler.where
offers no advantage overapplymap
since internally it just restructures the callable and usesapplymap
itself: