Skip to content

BUG: Support numpy.random.Generator as random_state input #40813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

BUG: Support numpy.random.Generator as random_state input #40813

wants to merge 3 commits into from

Conversation

jamesmyatt
Copy link
Contributor

@jamesmyatt
Copy link
Contributor Author

I don't think this is actually a good idea. I think it's better to change random_state to produce Generator directly, rather than RandomState. Then this will be fixed directly.

@jamesmyatt jamesmyatt closed this Apr 7, 2021
@jamesmyatt
Copy link
Contributor Author

Also I don't understand why the MacOS tests failed (timeout)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jamesmyatt