Skip to content

Subprocess to validate flake8 #40812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Apr 9, 2021
Merged

Subprocess to validate flake8 #40812

merged 6 commits into from
Apr 9, 2021

Conversation

hasan-yaman
Copy link
Contributor

@MarcoGorelli MarcoGorelli self-requested a review April 6, 2021 20:01
MarcoGorelli
MarcoGorelli suggested changes Apr 6, 2021
View reviewed changes
Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks @hasan-yaman ! Looks almost right

Can you check that

pytest scripts/tests/test_validate_docstrings.py

passes?

@hasan-yaman
Copy link
Contributor Author

Thanks @MarcoGorelli for your comments!

I updated the PR. Now it passes

pytest scripts/tests/test_validate_docstrings.py

MarcoGorelli
MarcoGorelli suggested changes Apr 7, 2021
View reviewed changes
MarcoGorelli
MarcoGorelli suggested changes Apr 7, 2021
View reviewed changes
Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating - just a few more comments, then it should be good to go

@jreback jreback added the Code Style Code style, linting, code_checks label Apr 7, 2021
@jreback jreback added this to the 1.3 milestone Apr 7, 2021
MarcoGorelli
MarcoGorelli approved these changes Apr 7, 2021
View reviewed changes
Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks @hasan-yaman !

@hasan-yaman
Copy link
Contributor Author

Hi @MarcoGorelli
I run the failed test locally, it passes without problem. (Actually, the changes made here, shouldn't effect the failed test case, i think)

Do you have any idea? How do we proceed from here?

@jreback jreback merged commit 2c3db15 into pandas-dev:master Apr 9, 2021
@jreback
Copy link
Contributor

jreback commented Apr 9, 2021

thanks @hasan-yaman

@jreback
Copy link
Contributor

jreback commented Apr 9, 2021

the failure is unrelated

@hasan-yaman hasan-yaman deleted the subprocess-to-validate-flake8 branch April 9, 2021 07:29
JulianWgs pushed a commit to JulianWgs/pandas that referenced this pull request Jul 3, 2021
@JulianWgs
Subprocess to validate flake8 (pandas-dev#40812)
823d84c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcoGorelli MarcoGorelli MarcoGorelli approved these changes

Assignees
No one assigned
Labels
Code Style Code style, linting, code_checks
Projects
None yet
Milestone
1.3
Development

Successfully merging this pull request may close these issues.

STYLE use subprocess to validate flake8 on docstrings instead of Application
3 participants
@hasan-yaman @jreback @MarcoGorelli