Skip to content

ENH: Upgrade sql module for SQLAlchemy 2.0 #40686 #40791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 25 commits into from
Closed

ENH: Upgrade sql module for SQLAlchemy 2.0 #40686 #40791

wants to merge 25 commits into from

Conversation

fangchenli
Copy link
Member

@github-actions
Copy link
Contributor

github-actions bot commented May 9, 2021

This pull request is stale because it has been open for thirty days with no activity. Please update or respond to this comment if you're still interested in working on this.

@github-actions github-actions bot added the Stale label May 9, 2021
@fangchenli fangchenli added Dependencies Required and optional dependencies IO SQL to_sql, read_sql, read_sql_query and removed Stale labels May 9, 2021
@fangchenli fangchenli marked this pull request as draft May 26, 2021 01:59
@fangchenli fangchenli marked this pull request as ready for review July 13, 2021 18:13
@fangchenli fangchenli marked this pull request as draft July 13, 2021 18:14
@jreback
Copy link
Contributor

jreback commented Oct 4, 2021

status here?

@fangchenli
Copy link
Member Author

status here?

This might require API change. I made a comment in #40686 (comment). If sqlalchemy won't release 2.0 soon, I think we could wait until we release 1.4 at the end of this year.

@mroeschke mroeschke mentioned this pull request Feb 6, 2022
Closed
4 tasks
@jreback
Copy link
Contributor

jreback commented Mar 6, 2022

@fangchenli status of this?

@fangchenli
Copy link
Member Author

@fangchenli status of this?

I'll close this for now.

@fangchenli fangchenli closed this Mar 16, 2022
@fangchenli fangchenli deleted the upgrade-sqlalchemy branch November 18, 2022 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke Awaiting requested review from mroeschke mroeschke will be requested when the pull request is marked ready for review mroeschke is a code owner

Assignees
No one assigned
Labels
Dependencies Required and optional dependencies IO SQL to_sql, read_sql, read_sql_query
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ENH: Upgrade Pandas SQLAlchemy code to be compatible with 2.0+ syntax
3 participants
@fangchenli @jreback @simonjayhawkins