Skip to content

future annotations #40785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 13, 2021
Merged

Conversation

MarcoGorelli
Copy link
Member

@MarcoGorelli MarcoGorelli marked this pull request as draft April 6, 2021 12:54
@jreback jreback added the Code Style Code style, linting, code_checks label Apr 8, 2021
@jreback
Copy link
Contributor

jreback commented Apr 8, 2021

sure, can you merge master once more and ping on green (of course in draft status)

@MarcoGorelli MarcoGorelli force-pushed the future-annotations branch 7 times, most recently from cad1880 to 3ea9fcd Compare April 13, 2021 10:36
@MarcoGorelli MarcoGorelli marked this pull request as ready for review April 13, 2021 11:21
@jreback jreback added this to the 1.3 milestone Apr 13, 2021
@jreback jreback merged commit 49c7791 into pandas-dev:master Apr 13, 2021
@jreback
Copy link
Contributor

jreback commented Apr 13, 2021

thanks @MarcoGorelli

@MarcoGorelli MarcoGorelli deleted the future-annotations branch April 13, 2021 12:27
JulianWgs pushed a commit to JulianWgs/pandas that referenced this pull request Jul 3, 2021
@rs2
Copy link
Contributor

rs2 commented Sep 30, 2021

@jreback @MarcoGorelli from __future__ import annotations is a Python 3.7+ feature*. Can I please check whether pandas no longer supports Python 3.6 and earlier versions of Python?

* See here: https://docs.python.org/3/whatsnew/3.7.html#pep-563-postponed-evaluation-of-annotations

@MarcoGorelli
Copy link
Member Author

@rs2 that's right, Python3.6 is no longer supported

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Style Code style, linting, code_checks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use from __future__ import annotations (almost?) everywhere?
3 participants