TYP: lib.pyi #40772
Merged
TYP: lib.pyi #40772
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jbrockmendel
commented
Apr 3, 2021
jbrockmendel
commented
- closes #xxxx
- tests added / passed
- Ensure all linting tests pass, see here for how to run them
- whatsnew entry
jbrockmendel
force-pushed
the
typ-no_default-2
branch
from
f2136a3 to
afdec85
Compare
| @@ -6,7 +6,10 @@ | |||
|
|
|||
| import numpy as np | |||
|
|
|||
| from pandas._libs.lib import no_default | |||
| from pandas._libs.lib import ( | |||
| NoDefault, | |||
There was a problem hiding this comment.
we should probably import from pandas._typing.
alternatively we could have no_default as 'Any' in pandas/_libs/lib.pyi and not need to have any reference to it in the function signatures which are visible to end users and could be confusing/misleading. we should never pass lib.no_default explicitly unless passing it along to a lower level function
JulianWgs
pushed a commit
to JulianWgs/pandas
that referenced
this pull request
Jul 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.