Skip to content

DOC/CI: temp pin of decorator (IPython dependency) #40768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 3, 2021

Conversation

jorisvandenbossche
Copy link
Member

The doc builds are failing since yesterday (in enhancingperf.rst, where using the cython ipython magic). By comparing the env from the last working / first failing build on master, one of the differences is a version bump of the decorator package, which is a dependency of IPython.

So checking if pinning this package fixes the issue.

@jorisvandenbossche jorisvandenbossche added Docs CI Continuous Integration labels Apr 3, 2021
@jorisvandenbossche
Copy link
Member Author

That fixes it, so going to merge this then to get CI green again.

@jorisvandenbossche
Copy link
Member Author

Opened an issue about it upstream: micheles/decorator#105

@MarcoGorelli MarcoGorelli added this to the 1.3 milestone Apr 3, 2021
@MarcoGorelli
Copy link
Member

Indeed, this fixes it, so merging, thanks @jorisvandenbossche

@MarcoGorelli MarcoGorelli merged commit 64f0844 into pandas-dev:master Apr 3, 2021
@jorisvandenbossche jorisvandenbossche deleted the ci-doc-decorator branch April 3, 2021 09:51
vladu pushed a commit to vladu/pandas that referenced this pull request Apr 5, 2021
* DOC/CI: temp pin of decorator (IPython dependency)

* add issue number
jorisvandenbossche added a commit to jorisvandenbossche/pandas that referenced this pull request Apr 6, 2021
sthagen added a commit to sthagen/pandas-dev-pandas that referenced this pull request Apr 6, 2021
Revert "DOC/CI: temp pin of decorator (IPython dependency) (pandas-dev#40768)" …
@simonjayhawkins
Copy link
Member

@meeseeksdev backport 1.2.x

@jorisvandenbossche
Copy link
Member Author

@simonjayhawkins this doesn't need to be backported, as it's already reverted on master

@jorisvandenbossche jorisvandenbossche modified the milestones: 1.2.4, 1.3 Apr 6, 2021
JulianWgs pushed a commit to JulianWgs/pandas that referenced this pull request Jul 3, 2021
* DOC/CI: temp pin of decorator (IPython dependency)

* add issue number
JulianWgs pushed a commit to JulianWgs/pandas that referenced this pull request Jul 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration Docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants