TYP: timedeltas.pyi #40766
Merged
TYP: timedeltas.pyi #40766
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@simonjayhawkins im pretty sure this is non-actionable based on what I read in python/mypy#1020, but would like your say-so before mothballing this |
|
yes. looks tricky. I would add ignores for now since imo the benefit of the added types outweighs the extra ignores. |
pandas/_libs/tslibs/timedeltas.pyi
Outdated
| from datetime import timedelta | ||
| from time import struct_time | ||
| from typing import ( | ||
| AnyStr, |
pandas/_libs/tslibs/timedeltas.pyi
Outdated
| from typing import ( | ||
| AnyStr, | ||
| ClassVar, | ||
| Optional, |
pandas/_libs/tslibs/timedeltas.pyi
Outdated
| AnyStr, | ||
| ClassVar, | ||
| Optional, | ||
| SupportsAbs, |
pandas/_libs/tslibs/timedeltas.pyi
Outdated
| Tuple, | ||
| Type, | ||
| TypeVar, | ||
| Union, |
pandas/_libs/tslibs/timedeltas.pyi
Outdated
| @@ -0,0 +1,106 @@ | |||
| from datetime import timedelta | |||
| from time import struct_time | |||
pandas/_libs/tslibs/timedeltas.pyi
Outdated
| import numpy as np | ||
|
|
||
| from pandas._libs.tslibs import ( | ||
| NaT, |
|
updated per comments |
yeshsurya
pushed a commit
to yeshsurya/pandas
that referenced
this pull request
Apr 21, 2021
yeshsurya
pushed a commit
to yeshsurya/pandas
that referenced
this pull request
May 6, 2021
JulianWgs
pushed a commit
to JulianWgs/pandas
that referenced
this pull request
Jul 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@simonjayhawkins mypy is unhappy about
Timedelta.__new__potentially returningNaT. Thoughts on how to handle this? (it'll come up again in Timestamp and Period)