Skip to content

TYP: indexes #40744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
Apr 13, 2021
Merged

TYP: indexes #40744

merged 17 commits into from
Apr 13, 2021

Conversation

jbrockmendel
Copy link
Member

  • closes #xxxx
  • tests added / passed
  • Ensure all linting tests pass, see here for how to run them
  • whatsnew entry

@jreback jreback added the Typing type annotations, mypy/pyright type checking label Apr 2, 2021
@jreback jreback added this to the 1.3 milestone Apr 2, 2021
@jbrockmendel
Copy link
Member Author

gentle ping; code checks are starting to touch nearby code

@jbrockmendel
Copy link
Member Author

rebased + green (and approved)

@jreback
Copy link
Contributor

jreback commented Apr 13, 2021

lgtm can you rebase as merged some future annotations stuff earlier, ping on green

@jreback
Copy link
Contributor

jreback commented Apr 13, 2021

pandas/core/groupby/generic.py:181: error: Cannot override final attribute "_obj_with_exclusions" (previously declared in base class "SelectionMixin") [misc]
pandas/core/groupby/generic.py:934: error: Cannot override final attribute "_obj_with_exclusions" (previously declared in base class "SelectionMixin") [misc]

@jbrockmendel
Copy link
Member Author

jbrockmendel commented Apr 13, 2021 via email

@jbrockmendel
Copy link
Member Author

rebased + greenish (mypy fixed by #40930, the other is an unrelated ResourceWarning)

@jreback jreback merged commit 88df92f into pandas-dev:master Apr 13, 2021
@jbrockmendel jbrockmendel deleted the cln-shared-docs branch April 13, 2021 17:19
JulianWgs pushed a commit to JulianWgs/pandas that referenced this pull request Jul 3, 2021
@jbrockmendel @JulianWgs
TYP: indexes (pandas-dev#40744)
82641e7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreback jreback jreback approved these changes

Assignees
No one assigned
Labels
Typing type annotations, mypy/pyright type checking
Projects
None yet
Milestone
1.3
Development

Successfully merging this pull request may close these issues.
2 participants
@jbrockmendel @jreback