COMPAT: matplotlib 3.4.0 #40718
Merged
COMPAT: matplotlib 3.4.0 #40718
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jbrockmendel
commented
Apr 1, 2021
•
jbrockmendel
commented
- closes BUG: MatplotlibDeprecationWarning: The is_first_col function was deprecated in Matplotlib 3.4 #40714
- tests added / passed
- Ensure all linting tests pass, see here for how to run them
- whatsnew entry
| @@ -760,6 +762,10 @@ def test_plot_scatter_with_c(self): | |||
|
|
|||
| # n.b. there appears to be no public method | |||
| # to get the colorbar label | |||
| if mpl_ge_3_4_0: | |||
| mark = pytest.mark.xfail(reason="_label attribute removed") | |||
There was a problem hiding this comment.
For recent versions, you can use ax.collections[0].colorbar.ax.get_ylabel() instead of the private attribute
jreback
added
the
Compat
|
marking this for backport as well. @jbrockmendel ping when ready . |
|
im kinda burned out on fixing-the-ci; can someone else pick up the baton on this? |
I could pick this up sometime later today |
|
ping @pandas-dev/pandas-core for merge. Thanks everyone! |
|
thanks all! |
|
@meeseeksdev backport 1.2.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/pandas
that referenced
this pull request
Apr 1, 2021
|
Hi, I just ran into this issue when running my matplotlib project based on pandas-input. Thanks for working on it. Please note, that matplotlib is now at 3.4.1 (3.4.0 was quickly superseded). Hth, |
vladu
pushed a commit
to vladu/pandas
that referenced
this pull request
Apr 5, 2021
simonjayhawkins
pushed a commit
that referenced
this pull request
Apr 6, 2021
Co-authored-by: jbrockmendel <[email protected]>
JulianWgs
pushed a commit
to JulianWgs/pandas
that referenced
this pull request
Jul 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.