Skip to content

REF: combine Block _can_hold_element methods #40709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 1, 2021

Conversation

jbrockmendel
Copy link
Member

which in turn lets us get rid of ObjectValuesExtensionBlock and HybridMixin.

Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great a couple of quetions

@jreback jreback added Internals Related to non-user accessible pandas implementation Refactor Internal refactoring of code labels Apr 1, 2021
@jreback jreback added this to the 1.3 milestone Apr 1, 2021
@jreback jreback merged commit e1dd032 into pandas-dev:master Apr 1, 2021
@jbrockmendel
Copy link
Member Author

Booyah! #40614 gets rid of two more Block subclasses, then #40149 gets us within spitting distance of another after that

@jbrockmendel jbrockmendel deleted the ref-can_hold_element branch April 1, 2021 23:13
vladu pushed a commit to vladu/pandas that referenced this pull request Apr 5, 2021
JulianWgs pushed a commit to JulianWgs/pandas that referenced this pull request Jul 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Internals Related to non-user accessible pandas implementation Refactor Internal refactoring of code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants