Skip to content

REF: de-duplicate pad/backfill code #40689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 31, 2021
Merged

REF: de-duplicate pad/backfill code #40689

merged 3 commits into from
Mar 31, 2021

Conversation

jbrockmendel
Copy link
Member

  • closes #xxxx
  • tests added / passed
  • Ensure all linting tests pass, see here for how to run them
  • whatsnew entry

simonjayhawkins
simonjayhawkins reviewed Mar 30, 2021
View reviewed changes
pandas/_libs/algos.pyx Outdated
fill_count = 0
val = values[i]
prev_mask = mask[i]
return pad_inplace(values[::-1], mask[::-1], limit=limit)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need the return?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nope, will remove

@simonjayhawkins simonjayhawkins added Algos Non-arithmetic algos: value_counts, factorize, sorting, isin, clip, shift, diff Clean labels Mar 30, 2021
@simonjayhawkins simonjayhawkins added this to the 1.3 milestone Mar 30, 2021
@jreback
Copy link
Contributor

jreback commented Mar 30, 2021

lgtm if you can address comment.

@jbrockmendel
Copy link
Member Author

updated + greenish

@jreback jreback merged commit caa5649 into pandas-dev:master Mar 31, 2021
@jbrockmendel jbrockmendel deleted the ref-backfill branch March 31, 2021 01:04
vladu pushed a commit to vladu/pandas that referenced this pull request Apr 5, 2021
@jbrockmendel @vladu
REF: de-duplicate pad/backfill code (pandas-dev#40689)
e9790ed
JulianWgs pushed a commit to JulianWgs/pandas that referenced this pull request Jul 3, 2021
@jbrockmendel @JulianWgs
REF: de-duplicate pad/backfill code (pandas-dev#40689)
9f0097c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonjayhawkins simonjayhawkins simonjayhawkins left review comments

Assignees
No one assigned
Labels
Algos Non-arithmetic algos: value_counts, factorize, sorting, isin, clip, shift, diff Clean
Projects
None yet
Milestone
1.3
Development

Successfully merging this pull request may close these issues.
3 participants
@jbrockmendel @jreback @simonjayhawkins